[Devel] Re: [PATCH 17/18] io-controller: IO group refcounting support

Gui Jianfeng guijianfeng at cn.fujitsu.com
Thu May 7 19:59:31 PDT 2009


Vivek Goyal wrote:
...
>  
> -		BUG_ON(!RB_EMPTY_ROOT(&st->active));
> -		BUG_ON(!RB_EMPTY_ROOT(&st->idle));
>  	}
>  
> -	BUG_ON(iog->sched_data.next_active != NULL);
> -	BUG_ON(iog->sched_data.active_entity != NULL);
> -	BUG_ON(entity->tree != NULL);
> +	/* Drop iocg reference on io group */

  We'd better to reset iog->iocg_id here since the cgroup is going to destroy.

> +	elv_put_iog(iog);
>  }
>  
> -/**


-- 
Regards
Gui Jianfeng


_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list