[Devel] Re: [RFC v14][PATCH 04/54] General infrastructure for checkpoint restart

[Oren Laadan]

Sukadev Bhattiprolu wrote:
> Oren Laadan [orenl at cs.columbia.edu] wrote:
> | +
> | +/* 'ckpt_debug_level' controls the verbosity level of c/r code */
> | +#ifdef CONFIG_CHECKPOINT_DEBUG
> | +
> | +/* FIX: allow to change during runtime */
> | +unsigned int __read_mostly ckpt_debug_level = CKPT_DDEFAULT;
> | +
> | +static __init int ckpt_debug_setup(char *s)
> | +{
> | +	ckpt_debug_level = strict_strtoul(s, NULL, 0);
> | +	return 0;
> | +}
> 
> Nit: Interchange NULL and 0 to suppress this ?
> 
> checkpoint/sys.c:384: warning: passing argument 2 of ‘strict_strtoul’
> makes integer from pointer without a cast

heh .. this was wrong to begin with. fixed in ckpt-v15.

Oren.

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers