[Devel] Re: [RFC v14][PATCH 08/54] Dump memory address space

[Dave Hansen]

On Tue, 2009-04-28 at 19:23 -0400, Oren Laadan wrote:
> +/* return (and detach) first empty page-array in the pool, if exists */
> +static inline struct ckpt_pgarr *pgarr_from_pool(struct ckpt_ctx *ctx)
> +{
> +       struct ckpt_pgarr *pgarr;
> +
> +       if (list_empty(&ctx->pgarr_pool))
> +               return NULL;
> +       pgarr = list_first_entry(&ctx->pgarr_pool, struct ckpt_pgarr, list);
> +       list_del(&pgarr->list);
> +       return pgarr;
> +}

What's the pool for, again?  If we're alloc/freeing a bunch of these,
I'd vote for a slab cache rather than managing our own pool.

-- Dave

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers