[Devel] Re: [PATCH] c/r: Add UTS support (v4)

[Serge E. Hallyn]

Quoting Dan Smith (danms at us.ibm.com):
> DH> for each ns in nsproxy {
> DH>   if (ns seen first time) {
> DH>     alloc ns_objref
> DH>     save state of ns
> DH>   } else {
> DH>     save existing ns_objref
> DH>   }
> DH> }
> 
> Isn't this precisely what I have in the latest patch?  Since there is
> only one supported namespace type, perhaps the for loop is hard to
> recognize...

Yes, I still think your patch is good...

> The bitfield serves only to describe which *new* namespace records
> follow the general one, but the objref of each (supported) namespace
> is included in the initial record.  Now that I think of it, I can do
> away with the bitfield to avoid confusion.

How about you tweak both Nathan and Oren (who I think both have
IPC c/r patchsets) by adding dummy ipc c/r support.  Just define
CR_OBJ_IPCNS, make cr_wrte_ns_ipc() empty and call it from
cr_write_namespaces().

-serge
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers