[Devel] Re: [RFC v14-rc][PATCH 07/23] Restore memory address space

[Oren Laadan]

Serge E. Hallyn wrote:
> Quoting Oren Laadan (orenl at cs.columbia.edu):
>> +	ret = -EINVAL;
>> +	if (hh->vdso != (unsigned long) mm->context.vdso)
>> +		goto out;
> 
> We were just talking about vdso+s390 on irc this morning,
> wondering about how to handle it...
> 
> Looking at arch/x86/vdso/vma.c, this seems like it should
> pretty much always error out.  The vdso base is set as a
> random offset above the stack base at exec().

Yes, I was wondering too ... :(

The default config is CONFIG_COMPAT_VDSO which disabled the
randomization, that's why it works for the default case on X86_32.

I think the code is mainly in arch/x86/vdso/vdso32_setup.c.

Oren.

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers