[Devel] Re: [RFC v14-rc][PATCH 20/23] Restore anonymous- and file-mapped- shared memory

[Dave Hansen]

On Fri, 2009-03-20 at 14:47 -0400, Oren Laadan wrote:
> 
> The bulk of the work is in cr_read_vma(), which has been refactored:
> the part that create the suitable 'struct file *' for the mapping is
> now larger and moved to a separate function. What's left is to read
> the VMA description, get the file pointer, create the mapping, and
> proceed to read the contents in.
> 
> Both anonymous shared VMAs that have been read earlier (as indicated
> by a look up to objhash) and file-mapped shared VMAs are skipped.
> Anonymous shared VMAs seen for the first time have their contents
> read in directly to the backing inode, as indexed by the page numbers
> (as opposed to virtual addresses).

This turns cr_write_vma() into a 120-line behemoth.  I'd really suggest
getting in there and trying to abstract things out a bit.  It is pretty
hard to follow as it stands.

-- Dave

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers