[Devel] Re: [PATCH] debug cgroup: remove unneeded cgroup_lock

[Paul Menage]

On Wed, Mar 11, 2009 at 6:47 PM, Li Zefan <lizf at cn.fujitsu.com> wrote:
> Since we are in cgroup write handler, so the cgrp is valid, so we
> don't have to hold cgroup_mutex when calling cgroup_task_count().
> One similar example is in cgroup_tasks_open().
>
> Signed-off-by: Li Zefan <lizf at cn.fujitsu.com>

Acked-by: Paul Menage <menage at google.com>

(Although this conflicts with a patch that I'm about to send out that
moves the code from cgroup_debug.c into cgroup.c to allow internal
details to be reported in the debug.* files.)

> ---
>  kernel/cgroup_debug.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/cgroup_debug.c b/kernel/cgroup_debug.c
> index daca620..0c92d79 100644
> --- a/kernel/cgroup_debug.c
> +++ b/kernel/cgroup_debug.c
> @@ -40,9 +40,7 @@ static u64 taskcount_read(struct cgroup *cont, struct cftype *cft)
>  {
>        u64 count;
>
> -       cgroup_lock();
>        count = cgroup_task_count(cont);
> -       cgroup_unlock();
>        return count;
>  }
>
> --
> 1.5.4.rc3
>
>
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers