[Devel] [PATCH] cls_cgroup: remove unneeded cgroup_lock

Li Zefan lizf at cn.fujitsu.com
Wed Mar 11 18:47:30 PDT 2009


We can remove this lock here, since we are in cgroup write handler
and thus the cgrp is guaranteed to be valid, and no lock is needed
when writing a u32 variable.

Signed-off-by: Li Zefan <lizf at cn.fujitsuc.com>
---
 net/sched/cls_cgroup.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/net/sched/cls_cgroup.c b/net/sched/cls_cgroup.c
index 91a3db4..1ab4542 100644
--- a/net/sched/cls_cgroup.c
+++ b/net/sched/cls_cgroup.c
@@ -62,13 +62,7 @@ static u64 read_classid(struct cgroup *cgrp, struct cftype *cft)
 
 static int write_classid(struct cgroup *cgrp, struct cftype *cft, u64 value)
 {
-	if (!cgroup_lock_live_group(cgrp))
-		return -ENODEV;
-
 	cgrp_cls_state(cgrp)->classid = (u32) value;
-
-	cgroup_unlock();
-
 	return 0;
 }
 
-- 
1.5.4.rc3

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list