[Devel] Re: [RFC][PATCH 00/11] track files for checkpointability

[Serge E. Hallyn]

Quoting Nathan Lynch (ntl at pobox.com):
> >From 3695fbda6225d2436e4af67a4bce6984df0891be Mon Sep 17 00:00:00 2001
> From: Nathan Lynch <ntl at pobox.com>
> Date: Mon, 9 Mar 2009 22:36:40 -0500
> Subject: [PATCH] ratelimit files_deny_checkpointing output
> 
> Any common distribution's boot sequence causes thousands of
> "<something> performed an action that cannot be checkpointed"
> messages.  Kernels are known to produce other messages of interest at
> times,

nonense...

> so ratelimit the output of files_deny_checkpointing.

Yes, please.

> Signed-off-by: Nathan Lynch <ntl at pobox.com>

Acked-by: Serge Hallyn <serue at us.ibm.com>

> ---
>  include/linux/checkpoint.h |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/checkpoint.h b/include/linux/checkpoint.h
> index 27366ac..efdb8f0 100644
> --- a/include/linux/checkpoint.h
> +++ b/include/linux/checkpoint.h
> @@ -108,8 +108,10 @@ static inline void __files_deny_checkpointing(const struct task_struct *tsk,
>  {
>  	if (!test_and_clear_bit(0, &files->may_checkpoint))
>  		return;
> -	printk(KERN_INFO "%s/%i performed an action that can not be "
> -	       "checkpointed at: %s:%d\n", tsk->comm, tsk->pid, file, line);
> +	if (printk_ratelimit())
> +		printk(KERN_INFO "%s/%i performed an action that can not be "
> +				"checkpointed at: %s:%d\n",
> +				tsk->comm, tsk->pid, file, line);
>  }
>  #define files_deny_checkpointing(tsk,f)				\
>  	__files_deny_checkpointing(tsk, f, __FILE__, __LINE__)
> -- 
> 1.6.0.6
> 
> _______________________________________________
> Containers mailing list
> Containers at lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/containers
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers