[Devel] Re: [PATCH 0/4] cgroups: show correct file mode

KAMEZAWA Hiroyuki kamezawa.hiroyu at jp.fujitsu.com
Mon Mar 2 16:09:50 PST 2009


On Mon, 2 Mar 2009 10:19:15 -0800
Paul Menage <menage at google.com> wrote:

> On Sun, Mar 1, 2009 at 6:13 PM, Li Zefan <lizf at cn.fujitsu.com> wrote:
> > Now a cgroup subsystem can set default file mode of its control files,
> > so here is a patchset to correct file mode of each subsystem's files.
> 
> I really think that we should be defaulting this based on whether the
> control file has read or write handlers.
> 
> Sure, there are special cases like "tasks" that we'd need to set a
> manual value for, but most of these patches would be unnecessary.
> 
like this ?
  
	int mode;
	if (cft->mode)
		mode = cft->mode;
	else if (cft->write_xxx || .....)
		mode = 0644;
	else
		mode = 0444;
Thanks,
-Kame

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list