[Devel] Re: [PATCH 1/1] cr: define CKPT_ARCH_NSIG for s390x

[Serge E. Hallyn]

Quoting Oren Laadan (orenl at cs.columbia.edu):
> 
> 
> Serge E. Hallyn wrote:
> > Else compilation fails on s390x.
> > 
> > Signed-off-by: Serge E. Hallyn <serue at us.ibm.com>
> > ---
> >  arch/s390/include/asm/checkpoint_hdr.h |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/s390/include/asm/checkpoint_hdr.h b/arch/s390/include/asm/checkpoint_hdr.h
> > index fc0ace8..a5aaa3e 100644
> > --- a/arch/s390/include/asm/checkpoint_hdr.h
> > +++ b/arch/s390/include/asm/checkpoint_hdr.h
> > @@ -79,6 +79,8 @@ struct ckpt_hdr_mm_context {
> >  	unsigned long asce_limit;
> >  };
> >  
> > +#define CKPT_ARCH_NSIG _SIGCONTEXT_NSIG
> > +
> 
> But _SIGCONTEXT_NSIG is defined within #ifdef __KERNEL__ ?

hmm?  hmm.  right, indirectly, failed to notice that...

Well I don't really like to just hard define it to 64 especially
without leaving a note at the sigcontext.h NSIG defines...

Should we define both it and the x86 version in <asm/signal.h>
not under #ifdef __KERNEL__?

-serge
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers