[Devel] Re: [PATCH 1/1] cr: uts: don't pass an unsigned var as a signed int

Oren Laadan orenl at cs.columbia.edu
Wed Jun 24 10:07:27 PDT 2009



Nathan Lynch wrote:

[...]

> "Serge E. Hallyn" <serge at hallyn.com> writes:

[...]

>> Oren,
>>
>> would it be possible to put up a filter, either manual or
>> automatic, to send every patch that gets pushed on the current
>> ckpt git branch to the containers list, maybe with a [CKPT PUSH]
>> tag in the subject line?
> 
> Or just post patches to the mailing list before committing them to
> public branches on which others are basing work.
> 
> This seems like an opportune moment to point out the guidelines for
> including a tree in linux-next:
> 
> all patches/commits in the tree/series must have been:
> 
> 	posted to a relevant mailing list
> 	reviewed
> 	unit tested
> 	destined for the next merge window (or the current release)
> 
> *before* they are included.
> 
> (source: http://lkml.org/lkml/2009/6/20/6 )
> 
> If upstream inclusion is the ultimate goal, those are the standards
> which apply.
> 
> 
>> I think it will foster much more review of every patch.  Right now
>> it feels like we just catch blatant bugs when they bite us too hard,
>> but I don't think many people are looking through 'git wc' every
>> day.

Yes, I agree with both suggestions, and will do both.

FWIW, I decided to push less-tested code to avoid delay for a long
period due to travel plans. Posting them on the list would have
helped to improve them, of course.

Oren.

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list