[Devel] [PATCH] Fixes for the deferqueue_add() function

[Dan Smith]

I'm not sure how the deferqueue would (or has ever) worked without these
modifications, but I had to make them in order to use it :)

Cc: orenl at cs.columbia.edu
Signed-off-by: Dan Smith <danms at us.ibm.com>
---
 kernel/deferqueue.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/kernel/deferqueue.c b/kernel/deferqueue.c
index efd99d5..470b8a3 100644
--- a/kernel/deferqueue.c
+++ b/kernel/deferqueue.c
@@ -66,18 +66,19 @@ int deferqueue_add(struct deferqueue_head *head, void *data, int size,
 {
 	struct deferqueue_entry *dq;
 
-	dq = kmalloc(sizeof(dq) + size, GFP_KERNEL);
+	dq = kmalloc(sizeof(*dq) + size, GFP_KERNEL);
 	if (!dq)
 		return -ENOMEM;
 
 	dq->function = func;
 	dq->destructor = dtor;
+	INIT_LIST_HEAD(&dq->list);
 	memcpy(dq->data, data, size);
 
 	pr_debug("%s: adding work %p func %p dtor %p\n",
 		 __func__, dq, func, dtor);
 	spin_lock(&head->lock);
-	list_add_tail(&head->list, &dq->list);
+	list_add_tail(&dq->list, &head->list);
 	spin_unlock(&head->lock);
 	return 0;
 }
-- 
1.6.0.4

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers