[Devel] Re: updates on ckpt-v16-dev

[Serge E. Hallyn]

Quoting Oren Laadan (orenl at cs.columbia.edu):
> 
> I pushed a bunch of updates on ckpt-v16-dev, including many fixes
> and support for zombies.
> 
> I did little testing, but preferred to shoot it out as I'll be out
> for the next 24 hours at least.
> 
> updates are to both user and kernel.
> 
> Serge: please review the patch that fixes the user namespace.

You removed the #include of <linux/init.h> from kernel/groups.c.
I hear that works ok for x86, but on s390 it breaks my compiles.

Also, in kernel/user_namespace.c:do_restore_userns() you have
a #ifdef CONFIG_USER_NS, but user_namespace.o only gets compiled
if CONFIG_USER_NS.

Otherwise the user_ns patch does look good.  I'm happy to do without
the hackier-feeling flag.

thanks,
-serge
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers