[Devel] Re: [PATCH 04/19] io-controller: Modify cfq to make use of flat elevator fair queuing

[Vivek Goyal]

On Thu, Jun 11, 2009 at 02:12:44PM +0800, Gui Jianfeng wrote:
> Vivek Goyal wrote:
> > This patch changes cfq to use fair queuing code from elevator layer.
> > 
> 
> last_end_request in cic is of no use anymore. Get rid of it.
> 

Thanks Gui. Queued for next posting.

Vivek

> Signed-off-by: Gui Jianfeng <guijianfeng at cn.fujitsu.com>
> ---
>  block/cfq-iosched.c       |    4 ----
>  include/linux/iocontext.h |    1 -
>  2 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
> index 5871568..705e7ba 100644
> --- a/block/cfq-iosched.c
> +++ b/block/cfq-iosched.c
> @@ -1170,7 +1170,6 @@ cfq_alloc_io_context(struct cfq_data *cfqd, gfp_t gfp_mask)
>  	cic = kmem_cache_alloc_node(cfq_ioc_pool, gfp_mask | __GFP_ZERO,
>  							q->node);
>  	if (cic) {
> -		cic->last_end_request = jiffies;
>  		INIT_LIST_HEAD(&cic->queue_list);
>  		INIT_HLIST_NODE(&cic->cic_list);
>  		cic->dtor = cfq_free_io_context;
> @@ -1794,9 +1793,6 @@ static void cfq_completed_request(struct request_queue *q, struct request *rq)
>  
>  	if (!cfq_class_idle(cfqq))
>  		cfqd->last_end_request = now;
> -
> -	if (sync)
> -		RQ_CIC(rq)->last_end_request = now;
>  }
>  
>  /*
> diff --git a/include/linux/iocontext.h b/include/linux/iocontext.h
> index 1fe9d78..9c4587b 100644
> --- a/include/linux/iocontext.h
> +++ b/include/linux/iocontext.h
> @@ -39,7 +39,6 @@ struct cfq_io_context {
>  
>  	struct io_context *ioc;
>  
> -	unsigned long last_end_request;
>  	sector_t last_request_pos;
>  
>  	unsigned int seek_samples;
> -- 
> 1.5.4.rc3
> 
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers