[Devel] Re: [RFC][v3][PATCH 6/7] Define do_fork_with_pids()

[Oren Laadan]

On Tue, 2 Jun 2009, Sukadev Bhattiprolu wrote:

> | >diff --git a/include/linux/types.h b/include/linux/types.h
> | >index 5abe354..17ec186 100644
> | >--- a/include/linux/types.h
> | >+++ b/include/linux/types.h
> | >@@ -204,6 +204,11 @@ struct ustat {
> | > 	char			f_fpack[6];
> | > };
> | > 
> | >+struct target_pid_set {
> | >+	int num_pids;
> | >+	pid_t *target_pids;
> | >+};
> | >+
> | 
> | A quick question: why not putting this definition into
> | include/linux/pid.h?
> 
> Well, the data structure needs to be visible to applications so I
> chose types.h since its already listed in fork(2) man page and the
> related type, 'pid_t' is defined there.

I don't recall linux/types.h mentioned in the manpage.

And, heh, it ended up within #ifdef __KERNEL__ there...
In fact, the types defined in that header are for kernel use.

Oren.

> 
> Isn't pid.h is a kernel-only file ?
> 
> 
> Sukadev
> 
> 
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers