[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

[Minoru Usui]

2009/6/1 jamal <hadi at cyberus.ca>:
> On Mon, 2009-06-01 at 06:06 +0000, Jarek Poplawski wrote:
>
>>
>> But how about that (of course extremely rude) case "tc filter replace"
>> is run with a new prio?
>
>
> Jarek, sir, handyman extraordinaire, handsome devil, and lover of
> kittens I humbly opine that we need to handle that case.
> How about going back to your original idea of defining tp_created? With
> apologies to Minoru (he must be thinking we are lunatics by now), how
> does the attached changed patch look to you?

It looks good to me, because it's simple and really understandable.
I think below issue should separate from above patch, because it's
easy to come to understand a patch.

How about that?
If it's ok, I'll test it tomorrow.

> Before you throw another rock, there is another issue which will be
> caused by this rude misconfig:
> "replace" really means "get rid of the old and add this new one".
> But for the last 50 years we do not "get rid of the old". I cant think
> of a clean way to do it sans shaving one of the kittens. One simple
> thing to do is to printk a warning when detecting this error. I think
> one needs to draw a line where bad config affects your life - in this
> case i dont think it is worth big changes..
>
> cheers,
> jamal
>
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers