[Devel] Re: build breaks when checkpoint unimplemented by arch

[Oren Laadan]

On Mon, 6 Jul 2009, Nathan Lynch wrote:

> Hi Oren,
> 
> With ckpt-v17-rc1 (as well as ckpt-v16-dev) the powerpc build is broken:
> 
> In file included from include/linux/checkpoint.h:28,
>                  from kernel/exit.c:53:
> include/linux/checkpoint_hdr.h:42:32: error: asm/checkpoint_hdr.h: No such file or directory
> In file included from include/linux/checkpoint.h:28,
>                  from kernel/exit.c:53:
> include/linux/checkpoint_hdr.h:410: error: 'CKPT_ARCH_NSIG' undeclared here (not in a function)
> make[1]: *** [kernel/exit.o] Error 1
> 
> 
> It appears that any architecture which does not supply
> asm/checkpoint_hdr.h is broken in the same way.
> 
> Either all architectures need to supply asm/checkpoint_hdr.h (and define
> CKPT_ARCH_NSIG), or there needs to be some other fix which allows
> as-yet-unsupported arches to build..
> 

I see... well - maybe it's time to resend the powerpc port :p

Until then, this patch worked for me to compile without c/r

Oren.


diff --git a/include/linux/checkpoint.h b/include/linux/checkpoint.h
index c47e796..b8f99be 100644
--- a/include/linux/checkpoint.h
+++ b/include/linux/checkpoint.h
@@ -19,6 +19,7 @@
 #define RESTART_TASKSELF	0x1
 
 #ifdef __KERNEL__
+#ifdef CONFIG_CHECKPOINT
 
 #include <linux/sched.h>
 #include <linux/nsproxy.h>
@@ -299,6 +300,7 @@ extern unsigned long ckpt_debug_level;
 
 #endif /* CONFIG_CHECKPOINT_DEBUG */
 
+#endif /* CONFIG_CHECKPOINT */
 #endif /* __KERNEL__ */
 
 #endif /* _LINUX_CHECKPOINT_H_ */
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers