[Devel] Re: [PATCH] cgroup: fix reverse unlock sequence in cgroup_get_sb

[Danny Feng]

On 07/22/2009 12:03 AM, Paul Menage wrote:
> On Tue, Jul 21, 2009 at 3:25 AM, Xiaotian Feng<dfeng at redhat.com>  wrote:
>> In cgroup_get_sb, the lock sequence is:
>>         mutex_lock(&inode->i_mutex);
>>         mutex_lock(&cgroup->mutex);
>> so the last unlock sequence should be:
>
> Make this "so for consistency the last ..." ?
>
> Maybe make the patch title "Make unlock sequence in cgroup_get_sb
> consistent" so someone looking through the change logs for fixes to
> backport doesn't wrongly thing that this fixes any bug"?
>

Yep, this is a trivial patch.  Modified following your suggestion, thank 
you.

>>         mutex_unlock(&cgroup->mutex);
>>         mutex_unlock(&inode->i_mutex);
>>
>> Signed-off-by: Xiaotian Feng<dfeng at redhat.com>
>
> Acked-by: Paul Menage<menage at google.com>
>
> Paul

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-cgroup-make-unlock-sequence-in-cgroup_get_sb-consistent.patch
Type: text/x-patch
Size: 852 bytes
Desc: not available
URL: <http://lists.openvz.org/pipermail/devel/attachments/20090722/d9c0863e/attachment.bin>
-------------- next part --------------
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers