[Devel] Re: [PATCH 0/2] c/r: Add s390 support

[Dan Smith]

DS> This set includes an updated version of the s390 patch as well as
DS> a new one that adds the common CR_COPY() macros suggested by Dave.

For the sake of comparison, the (trimmed) diffstat of the original
patch was:

 arch/s390/include/asm/checkpoint_hdr.h |   99 +++++++++++++++++++++++++++
 arch/s390/mm/checkpoint.c              |  106 +++++++++++++++++++++++++++++
 arch/s390/mm/restart.c                 |  117 ++++++++++++++++++++++++++++++++
 8 files changed, 341 insertions(+), 2 deletions(-)

and after the macros it was

 arch/s390/include/asm/checkpoint_hdr.h |   84 +++++++++++++++++++++++++
 arch/s390/mm/checkpoint.c              |  104 ++++++++++++++++++++++++++++++++
 arch/s390/mm/restart.c                 |   71 ++++++++++++++++++++++
 8 files changed, 278 insertions(+), 2 deletions(-)

That's a savings of ~60 lines in the affected bits.  Personally, I
think that it makes the save/load bits significantly easier to read as
well.

-- 
Dan Smith
IBM Linux Technology Center
email: danms at us.ibm.com

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers