[Devel] Re: [PATCH 5/7][v8] zap_pid_ns_process() should use force_sig()

Oleg Nesterov oleg at redhat.com
Thu Feb 19 10:59:54 PST 2009


On 02/18, Sukadev Bhattiprolu wrote:
>
>  	read_lock(&tasklist_lock);
>  	nr = next_pidmap(pid_ns, 1);
>  	while (nr > 0) {
> -		kill_proc_info(SIGKILL, SEND_SIG_PRIV, nr);
> +		rcu_read_lock();
> +
> +		/*
> +		 * Use force_sig() since it clears SIGNAL_UNKILLABLE ensuring
> +		 * any nested-container's init processes don't ignore the
> +		 * signal
> +		 */
> +		task = pid_task(find_vpid(nr), PIDTYPE_PID);
> +		force_sig(SIGKILL, task);

Shouldn't we check task != NULL ?

Oleg.

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list