[Devel] Re: [RFC][PATCH 1/5] Unroll essentials of do_remount_sb() into devpts

Christoph Hellwig hch at lst.de
Sun Feb 1 08:34:40 PST 2009


On Wed, Jan 28, 2009 at 10:45:47PM -0800, Sukadev Bhattiprolu wrote:
> +	fsi = DEVPTS_SB(s);
> +	opts = &fsi->mount_opts;
> +	parse_mount_options(data, PARSE_REMOUNT, opts);

You could probably get rid of at least the fsi variable without making the
code less readable.  Independent of these cosmetic bits the patch looks
good to me.

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list