[Devel] Re: [PATCH RFC v2 1/4] cgroup: implement eventfd-based generic API for notifications

[Kirill A. Shutemov]

On Tue, Dec 15, 2009 at 11:35 AM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu at jp.fujitsu.com> wrote:
> On Tue, 15 Dec 2009 11:11:16 +0200
> "Kirill A. Shutemov" <kirill at shutemov.name> wrote:
>
>> Could anybody review the patch?
>>
>> Thank you.
>
> some nitpicks.
>
>>
>> On Sat, Dec 12, 2009 at 12:59 AM, Kirill A. Shutemov
>> <kirill at shutemov.name> wrote:
>
>> > +       /*
>> > +        * Unregister events and notify userspace.
>> > +        * FIXME: How to avoid race with cgroup_event_remove_work()
>> > +        *        which runs from workqueue?
>> > +        */
>> > +       mutex_lock(&cgrp->event_list_mutex);
>> > +       list_for_each_entry_safe(event, tmp, &cgrp->event_list, list) {
>> > +               cgroup_event_remove(event);
>> > +               eventfd_signal(event->eventfd, 1);
>> > +       }
>> > +       mutex_unlock(&cgrp->event_list_mutex);
>> > +
>> > +out:
>> >        return ret;
>> >  }
>
> How ciritical is this FIXME ?
> But Hmm..can't we use RCU ?

It's not reasonable to have RCU here, since event_list isn't mostly-read.
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers