[Devel] Re: [PATCH 7/8] Adds functionality to read/write lock CLONE_THREAD fork()ing per-threadgroup

[Andrew Morton]

On Wed, 19 Aug 2009 19:45:11 -0700
Paul Menage <menage at google.com> wrote:

> On Wed, Aug 19, 2009 at 7:39 PM, Li Zefan<lizf at cn.fujitsu.com> wrote:
> >
> >> + __ __ __ __ __ __ list_for_each_entry_rcu(p, &tsk->thread_group, thread_group) {
> >> + __ __ __ __ __ __ __ __ __ __ if (p->sighand) {
> >> + __ __ __ __ __ __ __ __ __ __ __ __ __ __ sighand = tsk->sighand;

(^^ who did that?)

> >
> > s/tsk->sighand/p->sighand
> 
> Good catch, thanks. Fixed.
> 

I see no fix anywhere so I did this:

--- a/kernel/cgroup.c~cgroups-add-functionality-to-read-write-lock-clone_thread-forking-per-threadgroup-fix
+++ a/kernel/cgroup.c
@@ -1557,7 +1557,7 @@ struct sighand_struct *threadgroup_fork_
 		rcu_read_lock();
 		list_for_each_entry_rcu(p, &tsk->thread_group, thread_group) {
 			if (p->sighand) {
-				sighand = tsk->sighand;
+				sighand = p->sighand;
 				break;
 			}
 		}

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers