[Devel] Re: [RFC v14][PATCH 08/54] Dump memory address space

[Guenter Roeck]

On Tue, Apr 28, 2009 at 09:11:28PM -0700, Serge E. Hallyn wrote:
> Quoting Oren Laadan (orenl at cs.columbia.edu):
> > +#if CONFIG_CHEKCPOINT
                ^^^^^^^^^^
CONFIG_CHECKPOINT ? 

Guenter

> > +static int special_mapping_checkpoint(struct ckpt_ctx *ctx,
> > +				      struct vm_area_struct *vma)
> > +{
> > +	char *name;
> > +
> > +	/*
> > +	 * Currently, we only handle VDSO/vsyscall special handling.
> > +	 * Even that, is very basic - we just skip the contents and
> > +	 * hope for the best in terms of compatilibity upon restart.
> > +	 */
> > +
> > +	if (vma->vm_flags & CKPT_VMA_NOT_SUPPORTED)
> > +		return -ENOSYS;
> > +
> > +	name = arch_vma_name(vma);
> > +	if (!name || strcmp(vma_name, "[vdso]"))
> 
> Not important except for bisect-safety, as it's fixed in the next
> patch, but this should be name, not vma_name.
> 
> -serge
> _______________________________________________
> Containers mailing list
> Containers at lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/containers
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers