[Devel] Re: [PATCH 0/7] cgroup: io-throttle controller (v14)

[Andrea Righi]

On Wed, Apr 22, 2009 at 09:09:16AM +0800, Gui Jianfeng wrote:
> Andrea Righi wrote:
> > On Tue, Apr 21, 2009 at 09:16:22AM +0800, Gui Jianfeng wrote:
> >> Andrea Righi wrote:
> >>> On Mon, Apr 20, 2009 at 04:39:29PM +0800, Gui Jianfeng wrote:
> >>>> Andrea Righi wrote:
> >>>> ...
> >>>>> Implementation
> >>>>> ~~~~~~~~~~~~~~
> >>>>> Patchset against latest Linus' git:
> >>>>>
> >>>>>   [PATCH 0/7] cgroup: block device IO controller (v14)
> >>>>>   [PATCH 1/7] io-throttle documentation
> >>>>>   [PATCH 2/7] res_counter: introduce ratelimiting attributes
> >>>>>   [PATCH 3/7] page_cgroup: provide a generic page tracking infrastructure
> >>>>>   [PATCH 4/7] io-throttle controller infrastructure
> >>>>>   [PATCH 5/7] kiothrottled: throttle buffered (writeback) IO
> >>>>>   [PATCH 6/7] io-throttle instrumentation
> >>>>>   [PATCH 7/7] export per-task io-throttle statistics to userspace
> >>>>   Hi Andrea,
> >>>>
> >>>>   I'd like to have a try this patchset, would you tell what's the kernel version
> >>>>   and bio-cgroup version based on?
> >>>>
> >>> Latest Linus' git is the kernel and bio-cgroup v7 (from
> >>> http://people.valinux.co.jp/~ryov/bio-cgroup/).
> >>   Sorry, I still can't apply it...
> >>
> >> [root at localhost linux-2.6.30-rc1]# patch -p1 --dry-run < ../cgroup-io-throttle-v14.patch                                                                                         patching file Documentation/cgroups/io-throttle.txt
> >> patching file block/Makefile
> >> patching file block/blk-core.c
> >> patching file block/blk-io-throttle.c
> >> patching file block/kiothrottled.c
> >> patching file fs/aio.c
> >> patching file fs/buffer.c
> >> Hunk #1 FAILED at 36.
> >> Hunk #2 FAILED at 669.
> >> 2 out of 2 hunks FAILED -- saving rejects to file fs/buffer.c.rej
> >> patching file fs/proc/base.c
> >> patching file include/linux/blk-io-throttle.h
> >> patching file include/linux/cgroup_subsys.h
> >> Hunk #1 succeeded at 49 (offset 6 lines).
> >> patching file include/linux/memcontrol.h
> >> Reversed (or previously applied) patch detected!  Assume -R? [n] n
> >> Apply anyway? [n] n
> >> Skipping patch.
> >> 2 out of 2 hunks ignored -- saving rejects to file include/linux/memcontrol.h.rej
> >> patching file include/linux/mmzone.h
> >> Hunk #1 FAILED at 607.
> >> Hunk #2 FAILED at 958.
> >> ...
> > 
> > Could you checkout the latest Linus' git?
> > 
> > $ git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git linux-2.6
> > 
> > Or at least try with 2.6.30-rc2. It should apply cleanly also to this
> > version.
> 
>   Yes, I tried them all, but didn't work. :(
>   Would you try "cgroup-io-throttle-v14.patch" too?

It works for me:

$ git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git linux-2.6
$ cd linux-2.6
$ wget http://download.systemimager.org/~arighi/linux/patches/io-throttle/cgroup-io-throttle-v14.patch
$ git apply cgroup-io-throttle-v14.patch
(no error reported)

The same for v13.

-Andrea
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers