[Devel] Re: [PATCH 19/30] cr: deal with nsproxy

[Serge E. Hallyn]

Quoting Alexey Dobriyan (adobriyan at gmail.com):
> To save nsproxy, or to not save nsproxy?
> 
> Don't think much, save it.
> 
> I argue that nsproxy should be removed totally, if someone thinks otherwise. ;-)

You've got Oren starting to agree with you too.  I personally don't
much care in principle, and your code looks very nice.

The way you do this and the uts patch, though, you (of course) bypass
the CAP_SYS_ADMIN check in copy_namespaces().  Which is fine for your
patchset, but a problem if we were to base a compromise patchset on
your patchset.

It of course also enforces the 'leakage' checks, which again is
subject to our whole-container c/r discussion.

But again, the code is nice, and I see no problems in it.

-serge
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers