[Devel] Re: [PATCH 09/30] x86_64: ifdef out struct thread_struct::ip

[Ingo Molnar]

* Ingo Molnar <mingo at elte.hu> wrote:

> 
> * Matt Helsley <matthltc at us.ibm.com> wrote:
> 
> > On Fri, Apr 10, 2009 at 06:35:22AM +0400, Alexey Dobriyan wrote:
> > > struct thread_struct::ip isn't used on x86_64, struct pt_regs::ip is used
> > > instead. 
> > > 
> > > kgdb should be reading 0, but I can't check it.
> > > 
> > > Signed-off-by: Alexey Dobriyan <adobriyan at gmail.com>
> > > ---
> > > 
> > >  arch/x86/include/asm/processor.h |    2 ++
> > >  arch/x86/kernel/kgdb.c           |    2 +-
> > >  2 files changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > --- a/arch/x86/include/asm/processor.h
> > > +++ b/arch/x86/include/asm/processor.h
> > > @@ -421,7 +421,9 @@ struct thread_struct {
> > >  	unsigned short		fsindex;
> > >  	unsigned short		gsindex;
> > >  #endif
> > > +#ifdef CONFIG_X86_32
> > >  	unsigned long		ip;
> > > +#endif
> > >  #ifdef CONFIG_X86_64
> > >  	unsigned long		fs;
> > >  #endif
> > 
> > Do these make struct thread_struct behave better in cachelines 
> > (smaller, less aliasing)? Can we really fit more in the slab du 
> > jour?
> > 
> > Otherwise it seems like we're littering these structs with #ifdefs 
> > and not really saving anything. [...]
> 
> Removing fields always saves memory (even if it does not show up 
> currently due to allocators cache-aligning sizes).

I mean: we always try to consider structure size reductions as if 
they saved real memory, even if they dont do so in the current 
layout and allocation patterns.

In reality only every 8th 8-byte reduction will result in a true 
64-byte cacheline reduction - but still we have to continue small 
reductions otherwise we wont ever get to the larger reductions in 
the first place.

I.e. Alexey's patch shows a real item worth checking, regardless of 
the current size and alignment scenario.

	Ingo
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers