[Devel] Re: [PATCH 09/10] Enable multiple instances of devpts

[Cedric Le Goater]

[ ... ]

> | >  	/*
> | >  	 * parse_mount_options() restores options to default values
> | > @@ -232,6 +246,8 @@ static int devpts_show_options(struct seq_file *seq, struct vfsmount *vfs)
> | >  	seq_printf(seq, ",mode=%03o", opts->mode);
> | >  #ifdef CONFIG_DEVPTS_MULTIPLE_INSTANCES
> | >  	seq_printf(seq, ",ptmxmode=%03o", opts->ptmxmode);
> | > +	if (opts->newinstance)
> | > +		seq_printf(seq, ",newinstance");
> | 
> | Is actually that something we want to show?  It doesn't seem
> | informative.
> 
> Without this users have no easy way of knowing whether they have a 
> private mount specially if they mounted from command line ?
> 
> Does it mislead or confuse ?

the mount options are already shown in /proc/self/mounts. I don't think you need
a show_options() op.

C.

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers