[Devel] Re: [PATCH 10/10] Document usage of multiple-instances of devpts

[Serge E. Hallyn]

Quoting sukadev at linux.vnet.ibm.com (sukadev at linux.vnet.ibm.com):
> Alan Cox [alan at lxorguk.ukuu.org.uk] wrote:
> | Ok I'm happy with this patch set. It appears correct as far as the tty
> | side is concerned, it looks sensible in terms of interface with the
> | devpts layer.
> 
> Alan, Peter: Thanks for review and feedback.
> 
> | 
> | Really depends what everyone else thinks about the vfs bits and the API
> 
> Maybe I should post to fsdevel, manpages, and lkml for the vfs/api changes. 
> 
> Serge, Eric, Pavel: Any comments on the patchset before I do that ?

No luck yet finding my random lockup (it *should* be obvious), but do
notice that you ignore the return value of get_sb_single() in
init_pts_mount().  Certainly that should be fixed.

-serge
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers