[Devel] Re: [RFC v4][PATCH 9/9] File descriprtors (restore)

Oren Laadan orenl at cs.columbia.edu
Tue Sep 9 18:49:42 PDT 2008



Dave Hansen wrote:
> On Tue, 2008-09-09 at 03:42 -0400, Oren Laadan wrote:
>> +static int cr_close_all_fds(struct files_struct *files)
>> +{
>> +       int *fdtable;
>> +       int n;
>> +
>> +       do {
>> +               n = cr_scan_fds(files, &fdtable);
>> +               if (n < 0)
>> +                       return n;
>> +               while (n--)
>> +                       sys_close(fdtable[n]);
>> +               kfree(fdtable);
>> +       } while (n != -1);
>> +
>> +       return 0;
>> +}
> 
> This needs to use an ERR_PTR().  It will save using the double-pointer.

I suppose you refer to the call to cr_scan_fds(): either 'fdtable'
or 'n' will have to pass-by-reference. Is it that you prefer it to be
	fdtable = cr_scan_fds(files, &n);
?

Oren.

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list