[Devel] Re: [PATCH 2/2] netns bridge: cleanup bridges during netns stop

[Stephen Hemminger]

On Sat, 6 Sep 2008 10:44:08 +0400
Alexey Dobriyan <adobriyan at gmail.com> wrote:

> Signed-off-by: Alexey Dobriyan <adobriyan at gmail.com>
> ---
> 
>  net/bridge/br.c         |   22 ++++++++++++++++------
>  net/bridge/br_if.c      |    4 ++--
>  net/bridge/br_private.h |    2 +-
>  3 files changed, 19 insertions(+), 9 deletions(-)
> 
> --- a/net/bridge/br.c
> +++ b/net/bridge/br.c
> @@ -28,6 +28,10 @@ static const struct stp_proto br_stp_proto = {
>  	.rcv	= br_stp_rcv,
>  };
>  
> +static struct pernet_operations br_net_ops = {
> +	.exit	= br_net_exit,
> +};
> +

Acked-by: Stephen Hemminger <shemminger at vyatta.com>

overall, this is fine, but you might want to think about making
pernet_operations const if possible in future.

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers