[Devel] [PATCH] fix bin/vznetaddbr to work with bash >= 3.2

Kir Kolyshkin kir at openvz.org
Mon Nov 17 10:31:14 PST 2008


Pulled, thanks!

Do you also want me to include this commit [1]?

[1] 
http://git.altlinux.org/people/ldv/packages/?p=vzctl.git;a=commit;h=21ef5d0cb75aa7c29d9438614e93cae313bb7f16

Dmitry V. Levin wrote:
> On Fri, Oct 24, 2008 at 10:56:17PM +0400, Kir Kolyshkin wrote:
>   
>> Anton, thanks for the patch.
>>
>> Added to GIT:
>> http://git.openvz.org/?p=vzctl;a=commit;h=34934b090b03a996f7bbcc9b13145390efc56eb6
>>
>> Will appear in vzctl >= 3.0.23.
>>     
>
> I rewrote this bin/vznetaddbr.in without bash-isms and ifconfig, see
> http://git.altlinux.org/people/ldv/packages/?p=vzctl.git;a=commit;h=vzctl-3.0.23-1-g93ef4d9
>
> Can be pulled from branch maint of
> git://git.altlinux.org/people/ldv/packages/vzctl
>
> Tested by Anton Protopopov.
>
>   
>> Anton Protopopov wrote:
>>     
>>> Hi.
>>>
>>> Script vznetaddbr would not work properly with bash >= 3.2 because of
>>>
>>> "Bash-3.2 changed the behavior of the [[ command's `=~' operator when the
>>> right-hand side was quoted: it matched the quoted portions as strings."
>>> (see
>>> http://git.altlinux.org/people/ldv/packages/?p=bash.git;a=commit;h=upstream
>>> for more datailes)
>>>
>>> So, with bash >= 3.2 no bridges will be added.
>>>
>>> Patch, that fixed that can be found in ``upstream-commits'' branch
>>> http://git.altlinux.org/people/aspsk/packages/?p=vzctl.git;a=shortlog;h=refs/heads/upstream-commits
>>> of my vzctl git:
>>> git://git.altlinux.org/people/aspsk/packages/vzctl.git
>>> <http://git.altlinux.org/people/aspsk/packages/vzctl.git>
>>>
>>> Anton
>>>       
>
>   




More information about the Devel mailing list