[Devel] Re: [PATCH] Dynamically allocate struct mem_cgroup_stat_cpu memory

Li Zefan lizf at cn.fujitsu.com
Thu Nov 13 19:52:41 PST 2008


CC: KAMEZAWA Hiroyuki <kamezawa.hiroyu at jp.fujitsu.com>
CC: Balbir Singh <balbir at linux.vnet.ibm.com>

Andrew Morton wrote:
> (cc containers at lists.osdl.org)
> 
> On Thu, 13 Nov 2008 17:42:01 +0100 Jan Blunck <jblunck at suse.de> wrote:
> 
>> When increasing NR_CPUS to 4096 the size of struct mem_cgroup is growing to
>> 507904 bytes per instance on x86_64. This patch changes the allocation of
>> struct mem_cgroup_stat_cpu to be based on the number of configured CPUs during
>> boot time. The init_mem_cgroup still is that huge since it stays statically
>> allocated and therefore uses the compile-time maximum.
>>

I think you can just remove init_mem_cgroup, because memcg doesn't require
early initialization (when kmalloc is not avaiable), and I found init_mem_cgroup
is not treated specially after greping 'init_mem_cgroup' in the code.


_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list