[Devel] Re: [RFC/PATCH 3/8]: CGroup Files: Move the release_agent file to use typed handlers

Paul Menage menage at google.com
Tue May 13 14:32:57 PDT 2008


On Tue, May 13, 2008 at 1:08 PM, Andrew Morton
<akpm at linux-foundation.org> wrote:
> On Mon, 12 May 2008 23:37:10 -0700
>  menage at google.com wrote:
>
>  > +             agentbuf = kmalloc(PATH_MAX, GFP_KERNEL);
>  > +             if (!agentbuf)
>  > +                     goto continue_free;
>  > +             strcpy(agentbuf, cgrp->root->release_agent_path);
>
>  Did we need to allocate all that memory, or would kstrdup() suffice?
>

kstrdup() would be fine. Fixed.

Paul
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list