[Devel] Re: sysfs : fix kobject rename with multiple namespaces
Daniel Lezcano
dlezcano at fr.ibm.com
Mon May 5 10:05:57 PDT 2008
Serge E. Hallyn wrote:
> The patch looks good to me, except I'd really rename this to
> 'sysfs_tag_eq'. Calling it 'cmp', returning 't1!=t2', then checking for
> !sysfs_tag_cmp really increases the amount of thinking i have to do to
> make sure everything is koshepillager :)
>
> Maybe it's just me.
I just wanted to have sysfs_tag_cmp returning zero when sysfs is
disabled in order to be consistent with other functions.
But if that hurts, I can change that to something more mindless.
Thanks for looking at the patch.
-- Daniel
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
More information about the Devel
mailing list