[Devel] Re: [PATCH net-2.6.26][IPV6]: Fix potential net leak and oops in ipv6 routing code.

David Miller davem at davemloft.net
Wed Mar 26 16:50:02 PDT 2008


From: Daniel Lezcano <dlezcano at fr.ibm.com>
Date: Wed, 26 Mar 2008 16:59:29 +0100

> Pavel Emelyanov wrote:
> > The commits f3db4851 ([NETNS][IPV6] ip6_fib - fib6_clean_all handle several 
> > network namespaces) and 69ddb805 ([NETNS][IPV6] route6 - Make proc entry 
> > /proc/net/rt6_stats per namespace) made some proc files per net.
> > 
> > Both of them introduced potential OOPS - get_proc_net can return NULL, but
> > this check is lost - and a struct net leak - in case single_open() fails the
> > previously got net is not put.
> > 
> > Kill all these bugs with one patch.
> > 
> > Signed-off-by: Pavel Emelyanov <xemul at openvz.org>
 ...
> Good catch. Thanks.
> 
> Acked-by: Daniel Lezcano <dlezcano at fr.ibm.com>

Applied, thanks everyone!




More information about the Devel mailing list