[Devel] Re: [PATCH 06/15] Introduce sysfs_sd_setattr and fix sysfs_chmod

Tejun Heo htejun at gmail.com
Thu Jul 3 23:40:19 PDT 2008

Eric W. Biederman wrote:
> Currently sysfs_chmod calls sys_setattr which in turn calls
> inode_change_ok which checks to see if it is ok for the current user
> space process to change tha attributes. Since sysfs_chmod_file has
> only kernel mode clients denying them permission if user space is the
> problem is completely inappropriate.
> Therefore factor out sysfs_sd_setattr which does not call
> inode_change_ok and modify sysfs_chmod_file to call it.
> In addition setting victim_sd->s_mode explicitly in sysfs_chmod_file
> is redundant so remove that as well.
> Thanks to Tejun Heo <htejun at gmail.com>, and
> Daniel Lezcano <dlezcano at fr.ibm.com> for working on this
> and spotting this case.
> Signed-off-by: Eric W. Biederman <ebiederm at xmission.com>

Acked-by: Tejun Heo <tj at kernel.org>

Containers mailing list
Containers at lists.linux-foundation.org

More information about the Devel mailing list