[Devel] Re: [PATCH][IPV6]: Mischecked tw match in __inet6_check_established.

[David Miller]

From: Pavel Emelyanov <xemul at openvz.org>
Date: Tue, 15 Jan 2008 12:22:52 +0300

> When looking for a conflicting connection the !sk->sk_bound_dev_if
> check is performed only for live sockets, but not for timewait-ed.
> 
> This is not the case for ipv4, for __inet6_lookup_established in
> both ipv4 and ipv6 and for other places that check for tw-s.
> 
> Was this missed accidentally? If so, then this patch fixes it and
> besides makes use if the dif variable declared in the function.
> 
> Fits both, net-2.6 and net-2.6.25.
> 
> Signed-off-by: Pavel Emelyanov <xemul at openvz.org>

This fix definitely looks correct.

I just sent Linus a pull request for other 2.6.24 fixes,
so I'll toss this into my net-2.6 tree tomorrow after
he pulls that stuff in.

Thanks!