[Devel] Re: [PATCH (resend)] Don't create tunnels with '%' in name.
David Miller
davem at davemloft.net
Tue Feb 26 23:51:47 PST 2008
From: Pavel Emelyanov <xemul at openvz.org>
Date: Wed, 27 Feb 2008 10:44:33 +0300
> Four tunnel drivers (ip_gre, ipip, ip6_tunnel and sit) can
> receive a pre-defined name for a device from the userspace.
> Since these drivers call the register_netdevice() (rtnl_lock,
> is held), which does _not_ generate the device's name, this
> name may contain a '%' character.
>
> Not sure how bad is this to have a device with a '%' in its
> name, but all the other places either use the register_netdev(),
> which call the dev_alloc_name(), or explicitly call the
> dev_alloc_name() before registering, i.e. do not allow for
> such names.
>
> This had to be prior to the commit 34cc7b, but I forgot to
> number the patches and this one got lost, sorry.
>
> Signed-off-by: Pavel Emelyanov <xemul at openvz.org>
Applied, thanks Pavel.
I've already sent a pull request to Linus an hour ago, so
this will get in next time around.
More information about the Devel
mailing list