[Devel] Re: [PATCH 12/12] Deprecate the find_task_by_pid
Andrew Morton
akpm at linux-foundation.org
Fri Feb 1 14:27:50 PST 2008
On Tue, 29 Jan 2008 17:09:55 +0300
Pavel Emelyanov <xemul at openvz.org> wrote:
> diff --git a/kernel/kgdb.c b/kernel/kgdb.c
> index 87b0463..6de0fd0 100644
> --- a/kernel/kgdb.c
> +++ b/kernel/kgdb.c
> @@ -621,7 +621,7 @@ static struct task_struct *getthread(struct pt_regs *regs, int tid)
> if (!tid)
> return NULL;
>
> - return find_task_by_pid(tid);
> + return find_task_by_pid_ns(tid, &init_pid_ns);
> }
>
> #ifdef CONFIG_SMP
The code I currently have here has changed. Is has grown a nice comment:
/*
* find_task_by_pid() does not take the tasklist lock anymore
* but is nicely RCU locked - hence is a pretty resilient
* thing to use:
*/
return find_task_by_pid(tid);
I updated the comment appropriately
(s/find_task_by_pid/find_task_by_pid_ns/). Please check that this was
true.
More information about the Devel
mailing list