[Devel] Re: [PATCH 1/2] mqueue ns: move mqueue_mnt into struct ipc_namespace

[Dave Hansen]

On Wed, 2008-12-17 at 12:52 -0600, Serge E. Hallyn wrote:
> > > +void mq_init_ns(struct ipc_namespace *ns) {
> > > +   ns->mq_queues_count  = 0;
> > > +   ns->mq_queues_max    = DFLT_QUEUESMAX;
> > > +   ns->mq_msg_max       = DFLT_MSGMAX;
> > > +   ns->mq_msgsize_max   = DFLT_MSGSIZEMAX;
> > > +   ns->mq_mnt           = mntget(init_ipc_ns.mq_mnt);
> > > +}
> > 
> > Heh, I read that as a structure definition at first!  Could you put
> that
> > bracket on a new line.
> 
> That's actually taken care of in the followup patch - same with
> mq_exit_ns.  Sorry about that.  (Still I'd rather not bother with
> the patch flux to change it just in this patch, since whenever
> I do that I inevitably mess up something else)

Ahh, ok.  I guess it is OK since it is temporary.

-- Dave

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers