[Devel] Re: [PATCH 1/3] ftrace: graph of a single function

Steven Rostedt rostedt at goodmis.org
Wed Dec 3 13:36:14 PST 2008


On Wed, 3 Dec 2008, Andrew Morton wrote:

> On Wed, 3 Dec 2008 16:10:38 -0500 (EST)
> Steven Rostedt <rostedt at goodmis.org> wrote:
> > > > +
> > > > +	seq_printf(m, "%s\n", str);
> > > 
> > > Can we use %pF here?
> > 
> > If there's a way to not print the "+offset".
> 
> Could be added, I guess.  I wonder if it would be
> reused elsewhere.

There's lots of places in ftrace that would use it, and probably clean up
a bunch of code in the process.

> 
> > blk_unplug looks much nicer than blk_unplug+0x78/0x278
> 
> <mutters something about in-kernel pretty-printers>

Huh? sorry I couldn't hear you. Could you speak up. ;-)

-- Steve

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list