[Devel] Re: [PATCH 3/3] cgroups: introduce link_css_set() to remove duplicate code

[Li Zefan]

Paul Menage wrote:
> On Fri, Nov 28, 2008 at 2:02 AM, Li Zefan <lizf at cn.fujitsu.com> wrote:
>> Add a common function link_css_set() to link a css_set to a cgroup.
>>
>> Signed-off-by: Li Zefan <lizf at cn.fujitsu.com>
> 
> Overall the change looks like an improvement, but:
> 
> - the new function could do with comments about the semantics of its
> parameters, particularly tmp_cg_links.

How about:

/**
 * link_css_set - a helper function to link a css_set to a cgroup
 * @ tmp_cg_links: cg_cgroup_link objects allocated by allocate_cg_links()
 * @ cg: the css_set to be linked
 * @ cgrp: the destination cgroup
 */
static void link_css_set(struct list_head *tmp_cg_links,
			 struct css_set *cg, struct cgroup *cgrp)

> - why are you renaming cgrp -> root_cgrp in cgroup_get_sb()? That
> seems like unnecessary churn.
> 

Because we are linking all the css_sets to the root cgroup, so I think root_cgrp
helps readability.

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers