[Devel] Re: [PATCH] devcgroup: remove unused variable

[Serge E. Hallyn]

Quoting Li Zefan (lizf at cn.fujitsu.com):
> 
> Signed-off-by: Li Zefan <lizf at cn.fujitsu.com>

Yup.

Acked-by: Serge Hallyn <serue at us.ibm.com>

thanks,
-serge

> ---
>  security/device_cgroup.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/security/device_cgroup.c b/security/device_cgroup.c
> index 9c625f6..d5c15a7 100644
> --- a/security/device_cgroup.c
> +++ b/security/device_cgroup.c
> @@ -355,7 +355,7 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
>  	struct dev_cgroup *cur_devcgroup;
>  	const char *b;
>  	char *endp;
> -	int retval = 0, count;
> +	int count;
>  	struct dev_whitelist_item wh;
> 
>  	if (!capable(CAP_SYS_ADMIN))
> @@ -432,7 +432,6 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
>  	}
> 
>  handle:
> -	retval = 0;
>  	switch (filetype) {
>  	case DEVCG_ALLOW:
>  		if (!parent_has_perm(devcgroup, &wh))
> -- 
> 1.5.4.rc3
> 
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers