[Devel] Re: [RFC][PATCH 1/8]: /dev/tty tweak in init_dev()
Alan Cox
alan at lxorguk.ukuu.org.uk
Thu Aug 21 02:19:02 PDT 2008
On Wed, 20 Aug 2008 19:26:21 -0700
sukadev at us.ibm.com wrote:
>
> From: Sukadev Bhattiprolu <sukadev at us.ibm.com>
> Subject: [RFC][PATCH 1/8]: /dev/tty tweak in init_dev()
>
> When opening /dev/tty, __tty_open() finds the tty using get_current_tty().
> When __tty_open() calls init_dev() it passes in this tty in '*ret_tty'.
> init_dev() ignores this and asks devpts again for the tty. Is that really
> necessary ?
NAK
This code has all changed. Please take a look at -next and expect it to
continue to do so further. Patches against -next are welcome and there is
also more room to rework stuff in -next as we are making big changes
anyway.
Also why not make use of tty->driver_data. It is there for drivers to use.
Alan
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
More information about the Devel
mailing list