[Devel] Re: [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get_saddr()

[Denis V. Lunev]

On Thu, 2008-08-14 at 16:04 -0400, Vlad Yasevich wrote:
> Hi Brian
> 
> Brian Haley wrote:
> > ---
> > 
> > diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c
> > index 483a01d..e0945d4 100644
> > --- a/net/sctp/ipv6.c
> > +++ b/net/sctp/ipv6.c
> > @@ -319,7 +319,8 @@ static void sctp_v6_get_saddr(struct sctp_sock *sk,
> >  			  __func__, asoc, dst, NIP6(daddr->v6.sin6_addr));
> >  
> >  	if (!asoc) {
> > -		ipv6_dev_get_saddr(dst ? ip6_dst_idev(dst)->dev : NULL,
> > +		ipv6_dev_get_saddr(NULL,
> > +				   dst ? ip6_dst_idev(dst)->dev : NULL,
> >  				   &daddr->v6.sin6_addr,
> >  				   inet6_sk(&sk->inet.sk)->srcprefs,
> >  				   &saddr->v6.sin6_addr);
> 
> 
> I think this needs to use sock_net(sctp_opt2s(sk)) instead of NULL.

this looks safe to me

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers