[Devel] Re: [PATCH 2/6] Container Freezer: Make refrigerator always available

Rafael J. Wysocki rjw at sisk.pl
Fri Aug 1 15:53:17 PDT 2008 

On Friday, 1 of August 2008, Matt Helsley wrote:
> 
> On Fri, 2008-08-01 at 16:27 +-0200, Thomas Petazzoni wrote:
> > Hi,
> > 
> > Le Thu, 31 Jul 2008 22:07:01 -0700,
> > Matt Helsley <matthltc at us.ibm.com> a +AOk-crit :
> > 
> > > --- a/kernel/Makefile
> > > +-+-+- b/kernel/Makefile
> > > @@ -5,7 +-5,7 @@
> > >  obj-y     = sched.o fork.o exec_domain.o panic.o printk.o +AFw
> > >  	    cpu.o exit.o itimer.o time.o softirq.o resource.o +AFw
> > >  	    sysctl.o capability.o ptrace.o timer.o user.o +AFw
> > > -	    signal.o sys.o kmod.o workqueue.o pid.o +AFw
> > > +-	    signal.o sys.o kmod.o workqueue.o pid.o freezer.o +AFw
> > 
> > I have the impression that the code in kernel/power/process.c was
> > compiled only if CONFIG_PM_SLEEP was set. Now that the code has been
> > moved to kernel/freezer.c, it is unconditionnaly compiled in every
> > kernel. Is that correct ?
> >
> > If so, is it possible to put this new feature under some
> > CONFIG_SOMETHING option, for people who care about the kernel size ?
> 
> 	How about making it depend on a combination of CONFIG variables?
> Here's an RFC PATCH. Completely untested.
> 
> Signed-off-by: Matt Helsley <matthltc at us.ibm.com>

Can you please also make the contents of include/linux/freezer.h depend on
CONFIG_FREEZER instead of CONFIG_PM_SLEEP?

Also, I'm not really sure if kernel/power/Kconfig is the right place to define
CONFIG_FREEZER.

Perhaps we should even move freezer.c from kernel/power to kernel
and define CONFIG_FREEZER in Kconfig in there.  Andrew, what do you think?

> ---
>  kernel/Makefile      |    3 +-+--
>  kernel/power/Kconfig |    3 +-+-+-
>  2 files changed, 5 insertions(+-), 1 deletion(-)
> 
> Index: linux-2.6.27-rc1-mm1/kernel/Makefile
> ===================================================================
> --- linux-2.6.27-rc1-mm1.orig/kernel/Makefile
> +-+-+- linux-2.6.27-rc1-mm1/kernel/Makefile
> @@ -5,7 +-5,7 @@
>  obj-y     = sched.o fork.o exec_domain.o panic.o printk.o +AFw
>  	    cpu.o exit.o itimer.o time.o softirq.o resource.o +AFw
>  	    sysctl.o capability.o ptrace.o timer.o user.o +AFw
> -	    signal.o sys.o kmod.o workqueue.o pid.o freezer.o +AFw
> +-	    signal.o sys.o kmod.o workqueue.o pid.o +AFw
>  	    rcupdate.o extable.o params.o posix-timers.o +AFw
>  	    kthread.o wait.o kfifo.o sys_ni.o posix-cpu-timers.o mutex.o +AFw
>  	    hrtimer.o rwsem.o nsproxy.o srcu.o semaphore.o +AFw
> @@ -24,6 +-24,7 @@ CFLAGS_REMOVE_sched_clock.o = -pg
>  CFLAGS_REMOVE_sched.o = -mno-spe -pg
>  endif
>  
> +-obj-$(CONFIG_FREEZER) +-= freezer.o
>  obj-$(CONFIG_PROFILING) +-= profile.o
>  obj-$(CONFIG_SYSCTL_SYSCALL_CHECK) +-= sysctl_check.o
>  obj-$(CONFIG_STACKTRACE) +-= stacktrace.o
> Index: linux-2.6.27-rc1-mm1/kernel/power/Kconfig
> ===================================================================
> --- linux-2.6.27-rc1-mm1.orig/kernel/power/Kconfig
> +-+-+- linux-2.6.27-rc1-mm1/kernel/power/Kconfig
> @@ -85,6 +-85,9 @@ config PM_SLEEP
>  	depends on SUSPEND || HIBERNATION || XEN_SAVE_RESTORE
>  	default y
>  
> +-config FREEZER
> +-	def_bool PM_SLEEP || CGROUP_FREEZER
> +-
>  config SUSPEND
>  	bool "Suspend to RAM and standby"
>  	depends on PM && ARCH_SUSPEND_POSSIBLE
> 
> 
> 
> 
> 


 ¹þÿ°þÿ ¦þÿ Ÿþÿ ˜þÿ þÿ `âÿ #: #' # #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ýýûXÓÌÎÿýýüÿýýüÿÍÆÉÿýýûÿýýüÿýýûÿÑÊÍÿòîïÿýýüÿýýüÿþþýÿÔÍÐÿÕÏÒÿðèéÿöïïÿöïðÿöïïÿöïïÿͼ¿ÿn}‘ÿ Fƒÿ0ˆµÿ8¡Õÿ@³îÿE¿úÿ•ìþÿ@Íþÿ1Åþÿºþÿ
°þÿ «þÿ ¢þÿ ™þÿ þÿ ‡þÿ Zàÿ #A #/ # #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ þþýýýûâÔÍÏÿüüúÿÎÇÊÿüûúÿüûúÿüûúÿüûúÿÒËÎÿóîîÿýýüÿÔÍÐÿÕÎÑÿõññÿùôôÿôìíÿõîïÿõíîÿôììÿíãäÿ©˜Ÿÿ%r™ÿ -oÿ Kÿ7§Þÿ=·ôÿD¿üÿŽéþÿ4Åþÿ!¼þÿ´þÿ ¬þÿ £þÿ ›þÿ ’þÿ ‹þÿ þÿ Wâÿ #D #2 # #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ üüúvÓÌÎÿñììÿüûúÿÏÇÊÿüûúÿüûúÿüûúÿüûúÿÓÌÏÿóîîÿÔÍÐÿôïðÿüûúÿöððÿòéêÿôìíÿôììÿòèèÿôììÿ¾«­ÿp}‘ÿ!q›ÿ 6sÿ 9~ÿ \³ÿ:ºùÿ?¿þÿ…åþÿ%¿þÿ¶þÿ ¬þÿ ¤þÿ œþÿ ”þÿ ‹þÿ þÿ zþÿ Sâÿ #D #3 # #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ üüúÓÌÎùÖÏÑÿûúøÿÏÇÊÿûúøÿûúùÿûúøÿûúùÿûûùÿÓÌÏÿòíîÿýýûÿú÷öÿôìíÿñçèÿóêëÿòèéÿðååÿñèçÿáÔÕÿ’vxÿm•ÿsŸÿ 7vÿ Fvÿ Gœÿ gÉÿ;»þÿ{ßþÿ¸þÿ¬þÿ ¥þÿ žþÿ •þÿ Žþÿ ‚þÿ {þÿ rþÿ Pàÿ #D #3 # #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ûúøœÔÍÏÿðêêÿúù÷ÿÏÇÊÿúø÷ÿúø÷ÿûúøÿûúøÿûúøÿÕÍÐÿòííÿöñðÿñçèÿñæçÿñçèÿñææÿîââÿðååÿñèçÿ­•—ÿorÿmšÿu¤ÿa§ÿ Dxÿ Zœÿ P®ÿ kÎÿsÛþÿ®þÿ ¦þÿ žþÿ –þÿ Žþÿ …þÿ }þÿ tþÿ lþÿ Màÿ #D #3 # #ÿÿÿ ÿÿÿ ÿÿÿ ûûø.ÔÍÏýÖÏÑÿúøöÿúøöÿúøöÿúøöÿúøöÿúø÷ÿúù÷ÿúù÷ÿÓÉÌÿéÝßÿïãäÿðåæÿðåæÿîââÿíààÿïããÿðæåÿàÓÓÿ‘vxÿi•ÿožÿwªÿƒ¿ÿr¦Äÿ Uœÿ f³ÿ T¶ÿ tâÿ pâÿ lâÿ hâÿ dâÿ `àÿ Zâÿ Vâÿ Ràÿ Màÿ ?Åÿ #D #3 # #ÿÿÿ ÿÿÿ ÿÿÿ úùö½×ÐÒÿïêéÿúøöÿù÷õÿúøöÿúøöÿúøöÿúøöÿ÷òñÿòééÿÒÂÆÿå×ÙÿïãäÿîáâÿëÜÜÿìÞÞÿíßßÿîââÿïäãÿ¯–˜ÿmo€ÿjšÿp£ÿz±ÿ‡Åÿ–Ýÿ¼âÿ a³ÿ mÂÿ Úÿ ‚Ýÿ ‰éÿ ’òÿ ˜úÿ œþÿ ŸþÿmÚÿLz•w #J #H #> #. # #ÿÿÿ ÿÿÿ ù÷õS×ÐÒÿúùöÿøöóÿù÷ôÿù÷ôÿù÷ôÿù÷õÿöðïÿñççÿíàáÿíàáÿνÁÿàÐÒÿêÚÚÿêÚÚÿêÜÛÿëÝÜÿíàßÿíáàÿÝÏÏÿ’uxÿh—ÿjžÿr©ÿ¹ÿŒËÿ›àÿ §ôÿƒÉóÿ kÅÿ ~Úÿ âÿ …ìÿ òÿ •üÿ ˜þÿ œþÿ iÚÿmÛÿOz™t #? #3 #$ # #ÿÿÿ ÷õñ÷õò׺°´ÿîçæÿøöóÿøõóÿöðïÿòêéÿïããÿëÜÝÿéÙÚÿèØÙÿè××ÿº¥©ÿÕÂÄÿéÙÙÿêÛÛÿêÜÛÿëÝÜÿìßÞÿíâàÿ®•–ÿjn€ÿfœÿk£ÿ	u°ÿ
¿ÿŒÏÿšáÿ ©ôÿ+²ýÿ‡Îüÿ xÚÿ zßÿ ‚éÿ Œõÿ ‘üÿ •þÿ ˜þÿ ›þÿ zìÿjÜÿWŒ®l #& # #
 #ÿÿÿ öô𶩫üÁ·¹ÿ¾°³ÿ»ª®ÿº¦ªÿ²šžÿ²™ÿ®•™ÿ«’–ÿ«’–ÿ¤ŠŽÿ®—šÿ¹¥©ÿÖÄÆÿéÚÙÿêÛÚÿëÝÜÿëÞÝÿìàÞÿÛÌÌÿ’txÿhŸÿhŸÿn©ÿx¸ÿ„ÅÿŽÒÿ™âÿ!«ôÿ/·ýÿ8¹þÿ¾ýþÿ¸øþÿ°õþÿ©òþÿ îþÿ–éþÿåþÿ‡âþÿÝþÿxÙþÿhÊþÿ #' # # #ÿÿÿ ˜†*˜†Ñµœ›ÿ¤„†ÿ ÿ¥†ˆÿ¦‡‰ÿ§‰‹ÿº ¢ÿº ¢ÿÁ©«ÿì®ÿË·¸ÿÖÅÆÿ×ÇÇÿéÚÙÿêÛÚÿéÛÚÿêÞÜÿêÞÜÿ­•–ÿg]|ÿ i¥ÿ h£ÿ q°ÿ {¾ÿƒÉÿŠÒÿ™âÿ$©ôÿ4·ýÿ@¾þÿœïþÿPÑþÿ?Ëþÿ-Áþÿ¹þÿ°þÿ ¦þÿ Ÿþÿ ˜þÿ þÿ `âÿ #0 # # #ÿÿÿ  #q\S؝‰…üÔÀÂÿÜÉÊÿÜÉÊÿÛÈÉÿÛÉÉÿÜÊÊÿÜÊÊÿ¸¤¨ÿÖÅÅÿÞÍÍÿÝÍÍÿÞÏÎÿèÚØÿèÚØÿéÜÚÿêÝÛÿ×ÉÈÿ–uvù1ÿ i©ÿ jªÿ r·ÿ }Äÿ ƒÌÿ Q¬ÿ™âÿ$«ôÿ2·ýÿFÀþÿ•ìþÿ@Íþÿ1Åþÿºþÿ
°þÿ «þÿ ¢þÿ ™þÿ þÿ ‡þÿ Zàÿ #< #* # #ÿÿÿ  #Q;0dq\SæÓ¼¼ÿàÎÎÿßÍÍÿßÍÍÿßÍÍÿÞÍÌÿßÎÎÿ¶¤§ÿÕÄÄÿÞÎÍÿßÏÎÿçØ×ÿèÚØÿèÚØÿèÚØÿéÜÙÿ©‘‘ÿ‡imÏ 0–ÿ k¯ÿ m²ÿ t¾ÿ }Èÿ „Ìÿ 4ÿ Q¯ÿ!©ôÿ4¸ýÿGÀþÿŽéþÿ4Åþÿ!¼þÿ´þÿ ¬þÿ £þÿ ›þÿ ’þÿ ‹þÿ þÿ Wâÿ #C #1 # #ÿÿÿ    V at 5È£ŠˆýÖÄÄÿàÏÎÿáÐÏÿáÑÐÿãÒÑÿãÒÑÿ´¢¥ÿÓÃÃÿåÖÔÿçÙ×ÿæØÕÿæØÖÿæØÖÿæÙÖÿÔÅÄÿ•tuú+$&V 2˜ÿ m·ÿ p»ÿ xÄÿ |Ëÿ ƒÍÿ ;”ÿ 5–ÿ ZÄÿ8¸ýÿPÂþÿ…åþÿ%¿þÿ¶þÿ ¬þÿ ¤þÿ œþÿ ”þÿ ‹þÿ þÿ zþÿ Sâÿ #D #3 # #ÿÿÿ ÿÿÿ w_YêÔ¿¾ÿàÏÎÿàÑÏÿáÑÐÿàÑÏÿáÒÐÿµ£¥ÿÓÄÃÿäÕÓÿäÖÓÿäÖÓÿãÖÓÿãÖÓÿãÖÓÿ¦ŽÿŠloÒ"J 3žÿ p¿ÿ qÂÿ wÈÿ }Ëÿ €Íÿ ;–ÿ =˜ÿ =«ÿ eÐÿTÇþÿ{ßþÿ¸þÿ¬þÿ ¥þÿ žþÿ •þÿ Žþÿ ‚þÿ {þÿ rþÿ Pàÿ #D #3 # #ÿÿÿ ÿÿÿ 
T?5¿ ˆ†ýåÖÔÿßÐÎÿßÐÎÿßÐÎÿßÐÎÿ²¡£ÿÑÂÁÿãÕÒÿãÕÒÿãÕÒÿáÔÐÿàÓÏÿÑÂÀÿ“rrù,%'V"E 5¤ÿ qÈÿ rÉÿ wËÿ zÌÿ ~ÍÿQ™Ãÿ =ÿ L¸ÿ VËÿ lÖÿ xâÿ sâÿ oâÿ kâÿ fâÿ bâÿ [Öÿ Zâÿ Vâÿ Râÿ @Åÿ #D #3 # #ÿÿÿ ÿÿÿ ÿÿÿ 


s[UéÒ¿½ÿÝÎÌÿÜÍÊÿÝÎÌÿÛÍÊÿ± ¡ÿ;½ÿàÒÎÿáÔÐÿÜÎËÿÞÐÍÿßÒÎÿ¥ŒŒÿ‰kmÖOB 3¥ÿ tÏÿ uÍÿ wËÿ zÌÿ ~Íÿ „Óÿf¬Úÿ L¼ÿ YÔÿ aßÿ zñÿ rñÿ töÿ }ýÿ „þÿ „þÿ pëÿ'çù #K #I #G #> #. # #ÿÿÿ ÿÿÿ ÿÿÿ 
R=4¦œ†‚ýãÕÑÿÛÍÊÿÚËÉÿÚÌÉÿ®Ÿÿ˼ºÿÞÑÍÿÜÍÊÿÜÎÊÿÛÍÉÿÊ»¹ÿpoû!kW1;Sa
4’þcÒþ uÐÿ uÌÿ uÌÿ |Íÿ ˆÓÿ”âÿr½óÿ [Öÿ bàÿ iëÿ põÿ vøÿ }þÿ ‚þÿ „þÿ oëÿlÙþ #I #C #; #0 #" # #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ 


pZRåκ¸ÿÙËÈÿ×ÈÅÿÖÇÄÿ¬›œÿȹ·ÿÙËÇÿÚËÇÿØÉÅÿØÉÅÿ¡‰ˆÿ„hiÝj]K-9S[6’ý^Ìþ sÌÿ wÌÿ |Íÿ ‡Óÿ™âÿ-«ôÿ~Ìýÿ bæÿ lïÿ röÿ xüÿ {þÿ þÿ ‚þÿ „þÿ ‰þÿqÙüQˆÏÏ #- # # #	 #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ 

M:1†˜‚~ýÊ»¹ÿÔÅÂÿÔÅÂÿ©˜™ÿŶ´ÿØÉÅÿÔÅÁÿÓÅÀÿÄ´±ÿŽnmüvi[
I?%/CV7’ý
ZÇþ wÌÿ }ÍÿˆÓÿ™âÿ6±ôÿM¿ýÿ…Óþÿ môÿ r÷ÿ wþÿ ~þÿ þÿ „þÿ ‡þÿ ‹þÿ ŒþÿqÙü #* # # # #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ 


jLDåɶ³ÿÒÿÿÐÁ¾ÿ¦•–ÿÁ²¯ÿÒÄ¿ÿѾÿÏÁ¼ÿœ„ƒÿƒefßmc

T	C:<"1U9‘ýWÅÿ }Íÿ ‡Óÿ™âÿ:³ôÿ[ÇýÿvÑþÿ¾ýþÿ¸øþÿ°õþÿ©òþÿ îþÿ–éþÿåþÿ‡âþÿÝþÿxÙþÿhÊþÿ #! # # #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ    P71gb]þó±ÿ̼¸ÿ¢’’ÿ¼®«ÿÏÀ»ÿ̽¸ÿ¼¬¨ÿŒljývi\

J<56=!O<‘üVÃÿ ‡Óÿœãÿ@µôÿbÊýÿ…ÚþÿœïþÿPÑþÿ?Ëþÿ-Áþÿ¹þÿ°þÿ ¦þÿ Ÿþÿ ˜þÿ þÿ `âÿ #0 # # #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ 
fHAÌ®«ÿȸ´ÿ ÿºª§ÿȸ³ÿȹ³ÿ—€~ÿceßmd

T	C83 36="N@”úYÌÿœæÿH¹öÿlÌýÿŽÝþÿ•ìþÿ@Íþÿ1Åþÿºþÿ
°þÿ «þÿ ¢þÿ ™þÿ þÿ ‡þÿ Zàÿ #< #) # #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ    	8-':pQJþºª§ÿ›‹Šÿ´¤¡ÿô®ÿ´£Ÿÿ{WSþwi\

J<4   2   1 125;#H£ù^ÞÿC¶ùÿlÍýÿ’ßþÿŽéþÿ4Åþÿ!¼þÿ´þÿ ¬þÿ £þÿ ›þÿ ’þÿ ‹þÿ þÿ Wâÿ #B #0 # #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ 
_D=¤¸¤ ÿ—†…ÿ°Ÿœÿ¿®©ÿ‘ywÿ{XUømd

U	C82   /   +   &!

%*R´öcçÿaÇþÿ”àþÿ…åþÿ%¿þÿ¶þÿ ¬þÿ ¤þÿ œþÿ ”þÿ ‹þÿ þÿ zþÿ Sâÿ #D #3 # #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ    
lNFô•ƒ‚ÿ«š–ÿ«™•ÿyUQþ!{i]
J;/   (   #         

	".X·óbéÿÕþÿ{ßþÿ¸þÿ¬þÿ ¥þÿ žþÿ •þÿ Žþÿ ‚þÿ {þÿ rþÿ Pàÿ #D #3 # #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ 

W>7~Švuÿ¥”ÿwXUÿ{XUømcR
	<+                    # # # #1]¸ñaæÿpÙþÿ®þÿ ¦þÿ žþÿ –þÿ Žþÿ …þÿ }þÿ tþÿ lþÿ Màÿ #D #3 # #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ 

hJCݤ’ŽÿwTOþ#xeU>
'                #  #  #  # # # #<j¶ä tâÿ pâÿ lâÿ hâÿ dâÿ `àÿ Zâÿ Vâÿ Ràÿ Màÿ Hàÿ #D #3 # #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ    

I4/W~]XÿŒllð]T>%       #  #  #  #  #  #  #  # # # # #) #7 #@ #D #D #D #D #D #D #D #D #= #. # #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ 
lUOµ7-.PE;%   ÿÿÿ  #  #  #  #  #  #  #  #  #  # # # # #$ #. #2 #3 #3 #3 #3 #3 #3 #3 #. #" # #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ    #"#$ +!&! # #ÿÿÿ ÿÿÿ  #  #  #  #  #  #  #  #  #  #  # # #	 # # # # # # # # # # # # # #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ  #! # # # #ÿÿÿ ÿÿÿ ÿÿÿ  #  #  #  #  #  #  #  #  #  #  #  #  # # # # # # # # # # # # # # #ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿÿ ÿÿ
-------------- next part --------------
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https:+AC8ALw-lists.linux-foundation.org+AC8-mailman+AC8-listinfo+AC8-containers

More information about the Devel mailing list