[Devel] Re: [PATCH] net: Fix running without sysfs

[Stephen Hemminger]

On Wed, 26 Sep 2007 17:48:10 -0600
ebiederm at xmission.com (Eric W. Biederman) wrote:

> 
> When sysfs support is compiled out the kernel still keeps and maintains
> the kobject tree.  So it is not safe to skip our kobject reference counting or 
> to avoid becoming members of the kobject tree.  It is safe to not add
> the networking specific sysfs attributes.
> 
> This patch removes the sysfs special cases from net/core/dev.c
> renames functions from netdev_sysfs_xxxx to netdev_kobject_xxxx
> and always compiles in net-sysfs.c
> 
> net-sysfs.c is modified with a CONFIG_SYSFS guard around the parts
> that are actually sysfs specific.
> 
> Signed-off-by: Eric W. Biederman <ebiederm at xmission.com>

Acked-by: Stephen Hemminger <shemminger at linux-foundation.org>

Looks good. It also fixes a use after-free in netdev_run_todo
when !CONFIG_SYSFS

-- 
Stephen Hemminger <shemminger at linux-foundation.org>
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers