[Devel] Re: [PATCH 5/5] Add fair "control groups" scheduler

Srivatsa Vaddagiri vatsa at linux.vnet.ibm.com
Mon Sep 24 10:18:20 PDT 2007


On Mon, Sep 24, 2007 at 09:58:15AM -0700, Randy Dunlap wrote:
> > +	config FAIR_CGROUP_SCHED
> > +		bool "Control groups"
> > +		depends on CGROUPS
> > +		help
> > +		   This option allows you to create arbitrary task groups
> > +		   using the "cgroup" psuedo filesystem and control
> > +		   the cpu bandwidth allocated to each such task group.
> > +		   Refer to Documentation/cgroups.txt for more information
> > +		   on "cgroup" psuedo filesystem.
> 
> Too much indentation.
> 
> s/cpu/CPU/g please.

will fix both.

> > +config RESOURCE_COUNTERS
> > +	bool "Resource counters"
> > +	help
> > +	  This option enables controller independent resource accounting
> > +          infrastructure that works with cgroups
> 
> Use tab + 2 spaces to indent help text.

This one was there before in -mm ..I just moved it below in the Kconfig
file. Neverthless will fix the coding-style here as well.

Thanks for your reviews!

-- 
Regards,
vatsa
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list